Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 of dpub computedrole tests #42986

Merged

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook commented Nov 7, 2023

Closes web-platform-tests/interop-accessibility#71

Also moves the manual tests (and manual-focused ReadMe) into a new manual directory

Related spec diffs depend on:

@cookiecrook cookiecrook requested review from spectranaut, jnurthen and rahimabdi and removed request for jnurthen and rahimabdi November 7, 2023 16:15
@@ -0,0 +1,3 @@
spec: https://w3c.github.io/dpub-aam/
suggested_reviewers:
- spectranaut
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewers, the file renaming below is just moving the manual files into a new "manual" directory. Scroll past those or collapse the dir to see the new file diff in ./role/roles.html

@cookiecrook
Copy link
Contributor Author

@mattgarrish just informed me that some of these roles are deprecated in the DPUB-ARIA spec... Changing to Draft PR to pull those out.

@cookiecrook cookiecrook marked this pull request as draft November 13, 2023 22:52
auto-merge was automatically disabled November 13, 2023 22:52

Pull request was converted to draft

@cookiecrook cookiecrook marked this pull request as ready for review November 14, 2023 08:40
@cookiecrook cookiecrook enabled auto-merge (squash) November 14, 2023 19:14
@cookiecrook cookiecrook requested a review from jnurthen November 14, 2023 23:03
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cookiecrook cookiecrook merged commit 2403cb2 into web-platform-tests:master Nov 16, 2023
@cookiecrook cookiecrook deleted the dpub-aam-computedrole branch November 16, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for DPUB-AAM role mapping
3 participants