Skip to content

Update WebAssembly exception tests. #38549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ms2ger merged 1 commit into from
Feb 16, 2023
Merged

Update WebAssembly exception tests. #38549

Ms2ger merged 1 commit into from
Feb 16, 2023

Conversation

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Feb 16, 2023 •
edited
Loading

@Ms2ger Ms2ger requested review from ioannad and takikawa February 16, 2023 14:34
@Ms2ger Ms2ger force-pushed the wasm-exn-2023-02-16 branch from 0ef3662 to a747b7f Compare February 16, 2023 14:38
@Ms2ger Ms2ger force-pushed the wasm-exn-2023-02-16 branch from a747b7f to 35cda26 Compare February 16, 2023 14:40
ioannad
ioannad approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@ioannad ioannad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@Ms2ger Ms2ger merged commit 88f6900 into master Feb 16, 2023
@Ms2ger Ms2ger deleted the wasm-exn-2023-02-16 branch February 16, 2023 16:43
aheejin added a commit to aheejin/wpt that referenced this pull request Feb 16, 2023
@aheejin
[wasm] Exception -> Tag in basic.tentative.any.js
d570b60 
This need to change in order to work with web-platform-tests#38549, which merged
WebAssembly/exception-handling#252.
@aheejin aheejin mentioned this pull request Feb 16, 2023
Merged
Ms2ger pushed a commit that referenced this pull request Feb 17, 2023
@aheejin @Ms2ger
[wasm] Exception -> Tag in basic.tentative.any.js
cde25e7 
This need to change in order to work with #38549, which merged
WebAssembly/exception-handling#252.
marcoscaceres pushed a commit that referenced this pull request Mar 28, 2023
@aheejin @marcoscaceres
[wasm] Exception -> Tag in basic.tentative.any.js
7f10c42 
This need to change in order to work with #38549, which merged
WebAssembly/exception-handling#252.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ioannad ioannad ioannad approved these changes

@takikawa takikawa Awaiting requested review from takikawa

Assignees

@titzer titzer

Labels

wasm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ms2ger @ioannad @titzer @wpt-pr-bot