URLPattern: Escape pattern baseURL values. #36923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 10, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4020802
branch
from
6863fae to
917e7d6
Compare
This addresses the problem described in this spec issue: whatwg/urlpattern#170 And this spec PR: whatwg/urlpattern#172 Bug: 1380534 Change-Id: I37b5f77e674f8c23ff59e6224d92c7a0d767e7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4020802 Commit-Queue: Ben Kelly <[email protected]> Reviewed-by: Jeremy Roman <[email protected]> Cr-Commit-Position: refs/heads/main@{#1071919}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4020802
branch
from
917e7d6 to
65895c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the problem described in this spec issue:
whatwg/urlpattern#170
And this spec PR:
whatwg/urlpattern#172
Bug: 1380534
Change-Id: I37b5f77e674f8c23ff59e6224d92c7a0d767e7cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4020802
Commit-Queue: Ben Kelly <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1071919}