Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL: forbid <, >, and ^ in hosts #23572

Merged
merged 2 commits into from
May 14, 2020
Merged

URL: forbid <, >, and ^ in hosts #23572

merged 2 commits into from
May 14, 2020

Conversation

rmisev
Copy link
Member

@rmisev rmisev commented May 13, 2020

See whatwg/url#459 for context.

@wpt-pr-bot wpt-pr-bot added the url label May 13, 2020
@rmisev rmisev mentioned this pull request May 13, 2020
Merged
domenic
domenic approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move the sc://\u001F!\"$&'()*+,-.;=_`{|}~/ test down into "Allowed host code points" too?

annevk pushed a commit to whatwg/url that referenced this pull request May 14, 2020
@ZYSzys
Forbid <, >, and ^ in hosts
302ba41 
Tests: web-platform-tests/wpt#23572.

Closes #458.
@domenic domenic merged commit 9ffe8f2 into web-platform-tests:master May 14, 2020
@rmisev rmisev deleted the host-cp branch May 26, 2020 10:06
@alwinb alwinb mentioned this pull request Jun 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@annevk annevk Awaiting requested review from annevk

@GPHemsley GPHemsley Awaiting requested review from GPHemsley

@mikewest mikewest Awaiting requested review from mikewest

@TimothyGu TimothyGu Awaiting requested review from TimothyGu

Assignees

@domenic domenic

Labels
url
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmisev @domenic @wpt-pr-bot