Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Import Maps] Migrate Jest-based parsing tests into JSON-based #21064

Merged
merged 1 commit into from
Jan 15, 2020
Merged

[Import Maps] Migrate Jest-based parsing tests into JSON-based #21064

merged 1 commit into from
Jan 15, 2020

Commits on Jan 15, 2020

  1. [Import Maps] Migrate Jest-based parsing tests into JSON-based 

    This CL

- Converts Jest-based parsing tests into JSONs
(with minor refinement, and removing test cases depending
on interoperability issues of underlying URL parsers),
- Adjust the JSON schema for parsing tests, and
- Removes imported resolution tests.

The test failures
(virtual/import-maps-without-builtin-modules/external/wpt/import-maps/common/parsing.tentative.html)
are due to WICG/import-maps#184, i.e.
whether `null` mappings are removed from parsed import map or not.

Bug: 1026809, WICG/import-maps#170
Change-Id: If1e53cbeafd44c1de1a7fa38ef646fcd5721b495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982509
Reviewed-by: Domenic Denicola <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#731910}
    @hiroshige-g @chromium-wpt-export-bot
    hiroshige-g authored and chromium-wpt-export-bot committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    9b27a5e View commit details
    Browse the repository at this point in the history