[Import Maps] Remove Blink internals dependency from WPT/import-maps/common #20601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 4, 2019
…common Quick draft. Note: https://web-platform-tests.org/writing-tests/testdriver-extension-tutorial.html provides two methods, `testdriver-vendor.js` and `testdriver-extra.js`. I'm not sure which method to use, but in this CL I used `testdriver-vendor.js` method, because - It was easier to implement. - So far the API is expected only for testing and not needed to be exposed for automation. This CL contradicts with: https://web-platform-tests.org/writing-tests/testdriver.html > NB: presently, testdriver.js only works in the top-level > test browsing context (and not therefore in any frame or > window opened from it). because `test_driver` is accessed from inside `<iframe>`s in this CL. Perhaps this is OK in this case, as the `resolve_module_specifier` implementation works inside <iframe>s, while other `test_driver` method might stop working there. Bug: 1026809, WICG/import-maps#170 Change-Id: I8684ec544382e3036b9885e09f0c3a4d97208da5
LukeZielinski
force-pushed
the
chromium-export-cl-1949446
branch
from
3cdc70f
to
fd0a733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick draft.
Note:
https://web-platform-tests.org/writing-tests/testdriver-extension-tutorial.html
provides two methods,
testdriver-vendor.jsandtestdriver-extra.js.I'm not sure which method to use, but in this CL
I used
testdriver-vendor.jsmethod, becauseexposed for automation.
This CL contradicts with:
https://web-platform-tests.org/writing-tests/testdriver.html
Bug: 1026809, WICG/import-maps#170
Change-Id: I8684ec544382e3036b9885e09f0c3a4d97208da5
Reviewed-on: https://chromium-review.googlesource.com/1949446
WPT-Export-Revision: 5a6d0d7336883a8295304a7fee02dce100647078