Merging generated clipboard API tests by hallvors · Pull Request #1242 · web-platform-tests/wpt

hallvors · 2014-09-13T09:12:51Z

These tests are generated from script elements inside spec source code using the Python script here:
http://dev.w3.org/2006/webapi/clipops/TC-generator/

AFBarstow · 2014-09-16T12:03:24Z

@hallvors awesome :-)!

sideshowbarker · 2014-12-06T00:30:55Z

See https://travis-ci.org/w3c/web-platform-tests/builds/43112700
The pathnames of three of the files that were renamed now exceed 150 chars:

$ python tools/scripts/lint.py
PATH LENGTH: /clipboard-apis/clipboardevent_interface_events_triggered_from_documentexeccommand_inside_trusted_events_do_affect_system_clipboard_copy_on_document.html longer than maximum path length (153 > 150)
PATH LENGTH: /clipboard-apis/clipboardevent_interface_events_triggered_from_documentexeccommand_inside_trusted_events_do_affect_system_clipboard_cut_on_document.html longer than maximum path length (152 > 150)
PATH LENGTH: /clipboard-apis/types_property_all_implementations_must_return_textplain_as_one_of_the_types_entries_when_there_is_plain_text_on_the_clipboard_paste_on_document.html longer than maximum path length (165 > 150)
There were 3 errors (PATH LENGTH: 3)

hallvors · 2015-07-26T17:51:25Z

One major issue I know about: all setTimeout() usage should be fixed to use testharness.js conventions.

Apart from that, further review is welcome :)

…various variants

…ery time the test suite is built

…y stuff

…hoppipolla.co.uk/showcomment?chain=12228

garykac · 2017-05-01T23:13:05Z

@gked This PR is possibly of interest to you since you were looking into migrating clipboard tests into WPT.

foolip · 2018-06-12T09:35:53Z

I found this PR linked in https://github.com/w3c/clipboard-apis/blob/18e871aba0be2849c67ea8416f7bdf26de30562c/README.md. What is the status of this, anyone planning to finish it?

gsnedders · 2018-08-31T17:22:04Z

Do we know if these were reviewed prior to landing in the clipboard API repo?

gsnedders

A couple of major issues from a quick glance where tests are actually manual.

gsnedders · 2018-08-31T17:31:37Z

clipboard-apis/support/_lib.js

+        }
+    }
+    if(typeof triggerTestManually==='function'){
+        /* Tests that require user interaction define a "triggerTestManually()" function.


All these tests need a -manual suffix.

gsnedders · 2018-08-31T17:36:02Z

clipboard-apis/cancelling_default_action_basic_test_copy_on_inputtext.html

+    (function(){
+        var t = async_test()
+        var dataToPaste="clipboard text" ;
+        var extPassCond="clipboard text" ;


Anything with an external pass condition can't be verified through JS and therefore needs to be -manual.

ShahriarNasseri · 2023-06-08T06:37:14Z

Could you delete w portable management.

tobie added clipboard-apis wg-webapps labels Sep 13, 2014

tobie added clipboard-apis wg-webapps labels Oct 10, 2014

hallvors mentioned this pull request Jul 22, 2015

The ClipboardEvent constructor is strange w3c/clipboard-apis#10

Closed

hallvors force-pushed the hallvors/clipboard-api-2 branch from deaf7d1 to 1301bbf Compare July 27, 2015 12:38

Hallvord R. M. Steen added 19 commits July 27, 2015 17:26

adding clipboard API tests

4a00c77

adding helper files

f6d5c93

Added script that extracts tests from spec source code and generates …

21cd455

…various variants

mostly minor fixes

9ee689a

giving test files more meaningful names, avoid numbers that change ev…

b00e6a1

…ery time the test suite is built

changed test order in testlist.rb

cd31aef

renaming some test because file names were too long, adding some new

ec7637c

Whitespace fixes and other stuff to make Travis happy

c9465e8

and a few more whitespace fixes in helper files

cad1fb7

dropping Ruby file listing test cases and code to generate it - legac…

0dda6bc

…y stuff

integrating test setup with testharness.js, addresses https://critic.…

6f7981d

…hoppipolla.co.uk/showcomment?chain=12228

small fixes for better testharness.js integration

3e0994b

removed two tests expecting execCommand(paste) to work

ec27e08

various testharness.js integration fixes and test errata

fa24da7

Remove pointless whitespace in front of test titles

a6f7313

removing clipboard event constructor config that is not being tested

0912abc

spec changed event object construction, tests need fixing

19df515

adding clipboard API tests

d5eeb16

mostly minor fixes

b009493

Hallvord R. M. Steen added 3 commits July 27, 2015 17:56

changing where buttons for manual result reporting go

a3144ac

removing local path and print statement

3cd1e2e

dropping unnecessary try usage, better testharness.js usage

ff638f9

hallvors force-pushed the hallvors/clipboard-api-2 branch from 68be7a9 to ff638f9 Compare July 27, 2015 16:02

Hallvord R. M. Steen added 3 commits August 3, 2015 10:14

new isTrusted tests

df3ee1b

Fixing execCommand() arguments

9378fb2

Clarify failure reason if cut fails by switching order of asserts

ba3da2a

wpt-pr-bot added the wg-webplatform label Feb 4, 2016

Reordering asserts to make failures easier to debug

ffd8b73

ayg closed this Aug 28, 2016

ayg deleted the hallvors/clipboard-api-2 branch August 28, 2016 13:58

gsnedders restored the hallvors/clipboard-api-2 branch August 28, 2016 20:17

gsnedders reopened this Aug 28, 2016

ayg closed this Oct 26, 2016

ayg deleted the hallvors/clipboard-api-2 branch October 26, 2016 17:38

ayg restored the hallvors/clipboard-api-2 branch October 26, 2016 18:04

ayg reopened this Oct 26, 2016

annevk mentioned this pull request Mar 16, 2017

Clean up test cases w3c/clipboard-apis#34

Open

wpt-pr-bot requested a review from garykac June 12, 2018 09:36

gsnedders requested changes Aug 31, 2018

View reviewed changes

gsnedders closed this Jan 24, 2020

gsnedders deleted the hallvors/clipboard-api-2 branch January 24, 2020 18:06

gsnedders restored the hallvors/clipboard-api-2 branch January 24, 2020 18:40

Hexcles reopened this Jan 24, 2020

RatStar811 approved these changes Nov 17, 2025

View reviewed changes

RatStar811 approved these changes Nov 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merging generated clipboard API tests#1242

Merging generated clipboard API tests#1242
hallvors wants to merge 42 commits intomasterfrom
hallvors/clipboard-api-2

hallvors commented Sep 13, 2014 •

edited by wpt-pr-bot

Loading

Uh oh!

AFBarstow commented Sep 16, 2014

Uh oh!

sideshowbarker commented Dec 6, 2014

Uh oh!

hallvors commented Jul 26, 2015

Uh oh!

garykac commented May 1, 2017

Uh oh!

foolip commented Jun 12, 2018

Uh oh!

gsnedders commented Aug 31, 2018

Uh oh!

gsnedders left a comment

Uh oh!

gsnedders Aug 31, 2018

Uh oh!

gsnedders Aug 31, 2018

Uh oh!

ShahriarNasseri commented Jun 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

hallvors commented Sep 13, 2014 • edited by wpt-pr-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AFBarstow commented Sep 16, 2014

Uh oh!

sideshowbarker commented Dec 6, 2014

Uh oh!

hallvors commented Jul 26, 2015

Uh oh!

garykac commented May 1, 2017

Uh oh!

foolip commented Jun 12, 2018

Uh oh!

gsnedders commented Aug 31, 2018

Uh oh!

gsnedders left a comment

Choose a reason for hiding this comment

Uh oh!

gsnedders Aug 31, 2018

Choose a reason for hiding this comment

Uh oh!

gsnedders Aug 31, 2018

Choose a reason for hiding this comment

Uh oh!

ShahriarNasseri commented Jun 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

hallvors commented Sep 13, 2014 •

edited by wpt-pr-bot

Loading