[Gecko Bug 1264182] Hide URL.createObjectURL from ServiceWorker #12339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The appropriate lifetime for URLs created with URL.createObjectURL turned out to be tricky to define, so it was decided to hide it from service workers altogether. (w3c/ServiceWorker#688) This commit implements this change and adds a web platform test to verify it. It also exposes the MediaSource variant of URL.createObjectURL in DedicatedWorker and SharedWorker contexts in order to comply with the WebIDL spec (see w3c/media-source#168 (comment)). Differential Revision: https://phabricator.services.mozilla.com/D2728 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1264182 gecko-commit: 40d4999db3191bca0aeb75a50b37537ad78102ed gecko-integration-branch: autoland gecko-reviewers: mrbkap, asuth
wpt-pr-bot
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The appropriate lifetime for URLs created with URL.createObjectURL turned
out to be tricky to define, so it was decided to hide it from service
workers altogether. (w3c/ServiceWorker#688)
This commit implements this change and adds a web platform test to verify it.
It also exposes the MediaSource variant of URL.createObjectURL in DedicatedWorker
and SharedWorker contexts in order to comply with the WebIDL spec (see
w3c/media-source#168 (comment)).
Differential Revision: https://phabricator.services.mozilla.com/D2728
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1264182
gecko-commit: 40d4999db3191bca0aeb75a50b37537ad78102ed
gecko-integration-branch: autoland
gecko-reviewers: mrbkap, asuth