Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up editing/run/* with variant #11436

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Jun 8, 2018

Part of #11269.

@wpt-pr-bot
Copy link
Collaborator

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@zcorpan zcorpan requested a review from Ms2ger June 8, 2018 15:39
@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 11, 2018

 1:04.86 TEST_START: /editing/run/backcolor.html
 1:05.17 pid:5269 JavaScript error: http://web-platform.test:8000/editing/include/tests.js, line 5610: ReferenceError: subsetTest is not defined
 1:05.23 TEST_STATUS: Test OK. Subtests passed 0/1. Unexpected 1
backcolor - HTML editing conformance tests
------------------------------------------
Expected PASS, got FAIL
ReferenceError: subsetTest is not defined

@zcorpan
Copy link
Member Author

zcorpan commented Jun 11, 2018

Oops, fixed.

@zcorpan zcorpan changed the title Split up editing/run/delete.html with variant Split up editing/run/* with variant Jun 12, 2018
@zcorpan
Copy link
Member Author

zcorpan commented Jun 12, 2018

Guessing CI failed because of too many tests being changed.

@zcorpan zcorpan requested a review from foolip August 22, 2018 11:24
@foolip
Copy link
Member

foolip commented Aug 22, 2018

The Firefox job failed because "Log reached capacity (3145728 bytes); output disabled." and then "No output has been received in the last 10m0s", which is possibly because of #12166.

Chrome also failed in this way. We just have too much output. @jugglinmike FYI.

@zcorpan zcorpan merged commit 8587af6 into master Aug 22, 2018
@zcorpan zcorpan deleted the zcorpan/editing-run-delete-timeout branch August 22, 2018 12:30
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request May 25, 2020
…kato

Some tests run separately after fixing
web-platform-tests/wpt#11436
so that we don't need sections for running all tests once.

And also this removes the pref setting of `editor.use_div_for_default_newlines`
since its default value was changed for several years ago and would be never
changed again.

Differential Revision: https://phabricator.services.mozilla.com/D76465
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 25, 2020
…kato

Some tests run separately after fixing
web-platform-tests/wpt#11436
so that we don't need sections for running all tests once.

And also this removes the pref setting of `editor.use_div_for_default_newlines`
since its default value was changed for several years ago and would be never
changed again.

Differential Revision: https://phabricator.services.mozilla.com/D76465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants