Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid uncaught exception in iframe if WebNFC is not supported #11271

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Avoid uncaught exception in iframe if WebNFC is not supported #11271

merged 1 commit into from
Jun 1, 2018

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented May 31, 2018

Part of #11269.

@zcorpan zcorpan requested a review from Honry May 31, 2018 12:27
Honry
Honry approved these changes Jun 1, 2018
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM

@Honry Honry merged commit dcdd59c into master Jun 1, 2018
@zcorpan zcorpan deleted the zcorpan/webnfc-timeout branch June 1, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Honry Honry Honry approved these changes

@alexshalamov alexshalamov Awaiting requested review from alexshalamov

@kenchris kenchris Awaiting requested review from kenchris

@zolkis zolkis Awaiting requested review from zolkis

Assignees
No one assigned
Labels
web-nfc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcorpan @Honry @wpt-pr-bot