Fail early if Feature Policy is not supported #11270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
approved these changes
Jun 11, 2018
| @@ -1,3 +1,7 @@ | |||
| // Feature test to avoid timeouts | |||
| function assert_feature_policy_supported() { | |||
| assert_not_equals(document.policy, undefined, 'document.policy'); | |||
There was a problem hiding this comment.
Maybe "Feature Policy is supported" as the description, since this isn't really about testing document.policy, and making it trivial to understand the failure reason?
foolip
approved these changes
Jun 11, 2018
|
This seems to be timing out in Travis because too many tests, and too verbose output. May need to admin-merge. |
|
@zcorpan I'll try rebasing first since @gsnedders fixed the verbosity. |
|
Actually, no, there was a timeout, which is #7660, still unresolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11269.