Skip to content

Commit

Permalink
Add Origin-Agent-Cluster opt-out for direct-socket tests.
Browse files Browse the repository at this point in the history
These direct socket tests don't work as WPT tests with Origin Isolation
(kOriginKeyedProcessesByDefault) enabled, since the non-default
port of the test server shows up in the lock_url used to determine
if direct-sockets are allowed or not, and this breaks the tests.
In real-world operation, direct-sockets are used in Chrome apps and
Isolated Web Apps, and neither of these will have non-default ports.
Opting these three tests out via the Origin-Agent-Cluster header
allows them to run in this non-standard test setup.

Bug: 40259221
Change-Id: I7c9349a715005b20ddc48edd5e7813bf749a38c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5675462
Reviewed-by: Andrew Rayskiy <[email protected]>
Commit-Queue: James Maclean <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1323503}
  • Loading branch information
W. James MacLean authored and chromium-wpt-export-bot committed Jul 5, 2024
1 parent 8fdaf8c commit 41c475b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Cross-Origin-Opener-Policy: same-origin
Cross-Origin-Embedder-Policy: require-corp
Permissions-Policy: direct-sockets=()
Origin-Agent-Cluster: ?0
1 change: 1 addition & 0 deletions direct-sockets/tcp_socket.https.html.headers
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Cross-Origin-Opener-Policy: same-origin
Cross-Origin-Embedder-Policy: require-corp
Permissions-Policy: direct-sockets=(self)
Origin-Agent-Cluster: ?0
1 change: 1 addition & 0 deletions direct-sockets/udp_socket.https.html.headers
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Cross-Origin-Opener-Policy: same-origin
Cross-Origin-Embedder-Policy: require-corp
Permissions-Policy: direct-sockets=(self)
Origin-Agent-Cluster: ?0

0 comments on commit 41c475b

Please sign in to comment.