Update offsetParent behavior in shadow trees

New behavior for offsetParent in shadow trees was discussed in [1] and [2]. This lead to a chromium patch [3] which changed the behavior. After [3] landed, the desired behavior in the discussions in [1] and [2] seemed to have changed. Unfortunately, the author of [3] was no longer working on chromium. This new behavior was then added to the spec and landed in webkit [4] and firefox [5], and a WPT was added for it [6]. This patch implements the new behavior to follow suit with webkit and firefox based on the WPT in [6]. Unfortunately, there are several tests which are either internal to chromium or are only passing in chromium which appear to oppose this new behavior and will have to be updated or removed: - external/wpt/css/css-contain/content-visibility/content-visibility-035.html - external/wpt/css/css-contain/content-visibility/content-visibility-044.html - fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html - shadow-dom/offsetParent.html For shadow-dom/offsetParent.html, I verified that firefox and safari both currently fail the same tests which this patch does. [1] WICG/webcomponents#497 [2] w3c/csswg-drafts#159 [3] https://chromium.googlesource.com/chromium/src/+/18d455ee833f6a30dcbe2755380861eb75cd9f6f [4] https://trac.webkit.org/changeset/239313/webkit [5] https://bugzilla.mozilla.org/show_bug.cgi?id=1514074 [6] https://wpt.fyi/results/shadow-dom/offsetParent-across-shadow-boundaries.html Fixed: 920069 Change-Id: I168edc5ad0e4fcb92d0c4a440623f2424b14a988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2775208 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: vmpstr <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/master@{#872658}
web-platform-tests · Apr 15, 2021 · 372ea22 · 372ea22
1 parent f4351ba
commit 372ea22
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/css/css-contain/content-visibility/content-visibility-035.html b/css/css-contain/content-visibility/content-visibility-035.html
@@ -7,6 +7,8 @@
 <meta name="assert" content="content-visibility hidden element's subtree cannot be focused">
 <meta name="assert" content="content-visibility hidden element's subtree can access layout values">
 
+<body style="margin: 0">
+
 <div id="host">
   <input id="slotted" type="text">
 </div>

diff --git a/css/css-contain/content-visibility/content-visibility-044.html b/css/css-contain/content-visibility/content-visibility-044.html
@@ -9,6 +9,8 @@
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 
+<body style="margin: 0">
+
 <div id=host>
 <input id=slotted>
 <script>