-
Notifications
You must be signed in to change notification settings - Fork 241
Add Baseline regression notes #3187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
34f003a
89c742b
fccb850
241e4e5
a96e279
f632460
e877da5
7fb07e2
29a5b9d
55513e5
778c3dc
6aea90b
7b6fdf2
37f5bb2
c2bd3c8
4654301
9177cfd
2614b11
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,15 @@ name: Popover | |
| description: The `popover` HTML attribute creates an overlay to display content on top of other page content. Popovers can be shown declaratively using HTML, or using the `showPopover()` method. | ||
| spec: https://html.spec.whatwg.org/multipage/popover.html | ||
| group: html | ||
| # TODO: https://github.com/web-platform-dx/web-features/issues/1971 | ||
| # Status changed: https://github.com/web-platform-dx/web-features/pull/1797 | ||
| # 2024-09-18 — low → false — Safari on iOS has a bug that prevents dismissing popovers by touch. | ||
| # References: | ||
| # - https://github.com/mdn/browser-compat-data/issues/22927 | ||
| # - https://bugs.webkit.org/show_bug.cgi?id=267688 | ||
| # notes: | ||
| # - date: 2024-09-18 | ||
| # category: baseline-regression | ||
| # previous_baseline_value: low | ||
| # message: > | ||
| # Safari on iOS has a bug that prevents light dismiss (tapping outside the element to close it). | ||
| # citations: | ||
| # - https://bugs.webkit.org/show_bug.cgi?id=267688 | ||
| # - https://github.com/mdn/browser-compat-data/issues/22927 | ||
|
Comment on lines
5
to
13
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When I opened this PR, I had written this note. However, the feature has since progressed. It occurred to me that we should not show irrelevant notes, so I commented it out. This is a rather new idea, so I'd like to delete this entirely, if we decide this is the right way to go. Other options considered: some sort of "historic" flag on notes that are no longer relevant, or filtering historic notes from the published package. I figured both of those added complexity that wouldn't be very useful to anyone, least of all developers.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I almost feel like we should have a linting step in place which checks that |
||
| status: | ||
| compute_from: | ||
| - api.HTMLElement.popover | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,6 @@ name: Streams | |
| description: The streams API creates, composes, and consumes continuously generated data. | ||
| spec: https://streams.spec.whatwg.org/ | ||
| group: streams | ||
| # TODO: https://github.com/web-platform-dx/web-features/issues/1971 | ||
| # Status changed: https://github.com/web-platform-dx/web-features/pull/2358, https://github.com/web-platform-dx/web-features/pull/2491 | ||
| # 2024-12-19 — low → false — Regressed status to match Caniuse, which considers support beginning at BYOB shipping. | ||
| # 2025-01-30 — false → high — Split BYOB into a separate "readable-byte-streams" feature. Linked that one to Caniuse. | ||
| # References: | ||
| # - https://caniuse.com/streams | ||
|
Comment on lines
-5
to
-10
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I fussed over this for a while and ended up deciding to omit the note entirely. The first note would say that the feature regressed, the second note would be some new category (advance? unregression?) showing that we more or less reverted the second note. It seemed to me that the correct course of action in that scenario would be to withdraw the note, so that's what I've done.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tend to agree. If our consumers really only care about baseline regressions, then we don't need a note here. Unless we have reasons to believe that the history of a feature would be useful. Which I don't think we do. |
||
| status: | ||
| compute_from: | ||
| - api.ReadableStream | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.