fix: should rerun all tests when setup file changes#779
Merged
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue in watch mode where changes to setup files did not trigger all tests to rerun. The implementation adds setup file tracking through chunk hash comparison, similar to how test file changes are detected, ensuring that any setup file modification causes a complete test rerun.
Key changes:
- Added
isWatchModeparameter to control when affected entry calculation is performed - Enhanced
calcEntriesToRerunto track setup file changes via chunk hashes and trigger full test reruns when detected - Refactored change detection logic into reusable
processEntryChangesfunction
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/core/runTests.ts | Extracted isWatchMode flag and passed it to createRsbuildServer to enable conditional affected entry calculation |
| packages/core/src/core/rsbuild.ts | Added setup file change tracking with separate chunk hash storage, early return logic to rerun all tests when setup changes, and refactored change detection into reusable helper function |
| packages/core/src/core/listTests.ts | Added isWatchMode: false parameter to disable affected entry calculation in list command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should rerun all tests when setup file changes.
Related Links
Checklist