Skip to content

Comments

fix(vscode): correct icon path#703

Merged
fi3ework merged 1 commit intomainfrom
fi3ework-patch-1
Nov 19, 2025
Merged

fix(vscode): correct icon path#703
fi3ework merged 1 commit intomainfrom
fi3ework-patch-1

Conversation

@fi3ework
Copy link
Member

@fi3ework fi3ework commented Nov 18, 2025

Summary

rstackjs/rstack-design-resources@147e658

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 18, 2025 13:29
@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for rstest-dev ready!

Name Link
🔨 Latest commit 5f99dde
🔍 Latest deploy log https://app.netlify.com/projects/rstest-dev/deploys/691c74bad7946e0008bb2156
😎 Deploy Preview https://deploy-preview-703--rstest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects an incorrect icon URL in the VSCode extension's preinstall script, changing it from the rspress logo to the proper rstest logo to match the package name.

  • Fixed the icon download URL from rspress-logo-512x512.png to rstest-logo-512x512.png

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fi3ework fi3ework merged commit 799e8e0 into main Nov 19, 2025
29 of 34 checks passed
@fi3ework fi3ework deleted the fi3ework-patch-1 branch November 19, 2025 03:04
@9aoy 9aoy mentioned this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants