Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new rs.getConfig API that allows users to retrieve the current runtime configuration for their test files. This complements the existing rs.setConfig and rs.resetConfig APIs.
Key Changes:
- Added
getConfig()method to the RstestUtilities interface that returns a RuntimeOptions object containing runtime configuration values - Implemented
getConfig()to return a defensive copy of the configuration, preventing external modifications - Updated test suite to validate the new API functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/types/mock.ts | Added type definition for the getConfig() method to the RstestUtilities interface |
| packages/core/src/runtime/api/utilities.ts | Implemented getConfig() method that returns a new object with selected runtime configuration properties |
| website/docs/en/api/rstest/utilities.mdx | Added English documentation for the new rstest.getConfig API with usage example |
| website/docs/zh/api/rstest/utilities.mdx | Added Chinese documentation for the new rstest.getConfig API with usage example |
| e2e/test-api/setConfig.test.ts | Updated test suite name to include getConfig and improved test assertions using helper methods |
| e2e/test-api/fixtures/setConfig.test.ts | Added test case to verify getConfig() returns expected configuration values |
| examples/node/test/index.test.ts | Added example usage of rs.getConfig() for demonstration purposes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
support get runtime config via
rs.getConfigAPI.Related Links
Checklist