feat(vscode): communicate with worker using ipc instead of websocket#691
Merged
fi3ework merged 1 commit intoweb-infra-dev:mainfrom Nov 14, 2025
Merged
feat(vscode): communicate with worker using ipc instead of websocket#691fi3ework merged 1 commit intoweb-infra-dev:mainfrom
fi3ework merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aabb3db to
7e3f7af
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the VSCode extension's worker communication by replacing WebSocket-based IPC with Node.js native IPC, reducing dependencies and improving architecture. The changes introduce an RPC-style API and a reusable logger infrastructure for both master and worker processes.
- Removed WebSocket dependencies (
ws,get-port,@types/ws) in favor of native Node.js IPC - Implemented a custom RPC framework using IPC message passing with typed method proxies
- Refactored logger architecture with a shared
BaseLoggerclass for both master and worker processes
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Removed WebSocket-related dependencies (ws, get-port, @types/ws) |
| packages/vscode/package.json | Updated devDependencies to remove WebSocket packages |
| packages/vscode/src/shared/rpc.ts | New RPC implementation using IPC for bidirectional communication |
| packages/vscode/src/shared/logger.ts | New shared base logger class with formatted output |
| packages/vscode/src/master.ts | Refactored to use IPC-based RPC instead of WebSocket connections |
| packages/vscode/src/worker/index.ts | Simplified worker to expose methods via RPC and use Promise.withResolvers |
| packages/vscode/src/worker/logger.ts | Worker logger now proxies log calls to master via RPC |
| packages/vscode/src/logger.ts | Master logger extends BaseLogger and outputs to VSCode channel |
| packages/vscode/src/types.ts | Removed WebSocket-specific type fields (type discriminators and id) |
| packages/vscode/src/utils.ts | Added promiseWithTimeout utility function |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fi3ework
reviewed
Nov 13, 2025
fi3ework
reviewed
Nov 13, 2025
fi3ework
approved these changes
Nov 14, 2025
Member
|
thank you for your contribution. 😇 |
Member
|
there's a conflict, after resolving, we're good to merge. |
5066ad1 to
3e0b66e
Compare
Collaborator
Author
|
done |
Member
|
thank you for the work again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Links
Checklist