Skip to content

Conversation

fi3ework
Copy link
Member

Summary

fixes a race where the VS Code extension finished its initial test-file scan after the test suite reconfigured rstest.testFileGlobPattern. previously the constructor kicked off scanAllTestFiles without awaiting it, so late completions could repopulate foo.test.ts even when only *.spec.* patterns were allowed.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 06:25
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for rstest-dev ready!

Name Link
🔨 Latest commit 3bd7496
🔍 Latest deploy log https://app.netlify.com/projects/rstest-dev/deploys/68edece6f8023100081b6501
😎 Deploy Preview https://deploy-preview-615--rstest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a race condition in the VS Code extension where the initial test file scan could complete after test pattern configuration changes, potentially repopulating test files that should be excluded by updated glob patterns.

  • Extracts the async scanAllTestFiles operation from the constructor into a separate initialize() method
  • Updates the activate() function to await the initialization before returning the extension instance

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@9aoy 9aoy merged commit 39dcf53 into main Oct 14, 2025
17 checks passed
@9aoy 9aoy deleted the bug-fic branch October 14, 2025 09:34
@9aoy 9aoy mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants