fix: should handle error string correctly #614
Merged
+49
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes error string handling in the test runtime to prevent crashes when tests reject with string values instead of Error objects.
- Adds string error handling in the
formatTestErrorfunction to wrap string errors in an object with a message property - Adds end-to-end test coverage for error string scenarios
- Updates migration documentation to include error handling examples
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/runtime/util.ts | Modified formatTestError to handle string errors by wrapping them in error objects |
| e2e/test-api/fixtures/errorString.test.ts | Added test fixture that rejects with a string to reproduce the bug |
| e2e/test-api/edgeCase.test.ts | Added test case to verify string error handling works correctly |
| website/docs/en/guide/migration/jest.mdx | Added documentation example for error handling in async tests |
| website/docs/zh/guide/migration/jest.mdx | Added Chinese translation of error handling documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| it('test error string', () => { | ||
| return new Promise((_resolve, reject) => { | ||
| reject('aaaa'); |
There was a problem hiding this comment.
[nitpick] The error message 'aaaa' is a magic string that doesn't provide meaningful context. Consider using a more descriptive error message like 'Test error string' to make the test intention clearer.
Suggested change
| reject('aaaa'); | |
| reject('Test error string'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
should handle error string correctly.
Related Links
Checklist