Conversation
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Timeless0911
previously approved these changes
Apr 17, 2025
Timeless0911
approved these changes
Apr 21, 2025
|
|
||
| const reactEntry = ` | ||
| import { render } from 'react-dom'; | ||
| import { createRoot } from 'react-dom/client'; |
Contributor
There was a problem hiding this comment.
react is the peerDependencies of @rspress/plugin-preview, we should update the peer range if we no longer support react 17.
|
We are getting an error when upgrading to Rspress v2.0.0-beta.0: Should we just ignore the error? Or could Rspress handle this (e.g.: bundle |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
react@19 and react-dom@19
Related Issue
Checklist