Skip to content

fix: normalize jsx img src attribute correctly#1979

Merged
SoonIter merged 1 commit intoweb-infra-dev:mainfrom
JounQin:fix/img_src
Mar 19, 2025
Merged

fix: normalize jsx img src attribute correctly#1979
SoonIter merged 1 commit intoweb-infra-dev:mainfrom
JounQin:fix/img_src

Conversation

@JounQin
Copy link
Collaborator

@JounQin JounQin commented Mar 19, 2025

Summary

Related Issue

Sorry this is a critical regression introduced by #1877, it's weird that TS didn't complain about Object.assign(string, ...)

cc @Timeless0911 @chenjiahan

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 2d621f9
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/67da86864caa9e0008739088
😎 Deploy Preview https://deploy-preview-1979--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 2d621f9
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67da868543243500084fb8f0
😎 Deploy Preview https://deploy-preview-1979--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 59 (🔴 down 33 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your fix

SoonIter
SoonIter previously approved these changes Mar 19, 2025
@SoonIter SoonIter enabled auto-merge (squash) March 19, 2025 08:54
auto-merge was automatically disabled March 19, 2025 08:55

Head branch was pushed to by a user without write access

@JounQin
Copy link
Collaborator Author

JounQin commented Mar 19, 2025

@SoonIter CI is green now after pnpm dedupe.

@SoonIter
Copy link
Member

@SoonIter CI is green now after pnpm dedupe.

Not because of this reason that CI is not green

module.d.ts is flasky introduced by #1968

@SoonIter
Copy link
Member

but run pnpm dedupe is what I expected too

so, merged

@SoonIter SoonIter enabled auto-merge (squash) March 19, 2025 09:09
@SoonIter SoonIter merged commit 8bd99ae into web-infra-dev:main Mar 19, 2025
11 checks passed
@JounQin JounQin deleted the fix/img_src branch March 19, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants