Skip to content

chore: bump napi 3.0.0-alpha.24 -> 3.0.0-alpha.33#9855

Merged
hardfist merged 3 commits intoweb-infra-dev:mainfrom
CPunisher:03-31-chore/napi
Apr 1, 2025
Merged

chore: bump napi 3.0.0-alpha.24 -> 3.0.0-alpha.33#9855
hardfist merged 3 commits intoweb-infra-dev:mainfrom
CPunisher:03-31-chore/napi

Conversation

@CPunisher
Copy link
Contributor

@CPunisher CPunisher commented Mar 31, 2025

Summary

This is necessary for rspack wasi.

There is a big break change: napi-rs/napi-rs#2401. Rust tuple passed into tsfn now becomes a single array arg in js. We should wrap it into FnArgs { data: (...) }.

Before: rs tsfn((a, b)) -> js tsfn(a,b)
After: rs tsfn((a, b)) -> js tsfn([a,b])
We need change to rs tsfn(FnArgs { data: (a, b) })/tsfn((a, b).into()) -> js tsfn(a,b)

Other changes:

  1. Buffer does not impl Clone any more: refactor!(napi): TypedArray API surfaces napi-rs/napi-rs#2462
  2. re-export ctor: fix!(napi): upgrade to ctor 0.3.6 napi-rs/napi-rs#2472

close: #9618

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 38b36fb
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67ea882317411e0009c1546e

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 31, 2025

CodSpeed Performance Report

Merging #9855 will not alter performance

Comparing CPunisher:03-31-chore/napi (38b36fb) with main (0a821ff)

Summary

✅ 8 untouched benchmarks

@hardfist hardfist merged commit 5a38e5b into web-infra-dev:main Apr 1, 2025
41 checks passed
@CPunisher CPunisher mentioned this pull request Apr 1, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Node.js assertion failure when running Rspack under Bazel, but works fine outside Bazel

2 participants