chore: bump inventory 0.1 -> 0.3#9159
Merged
jerrykingxyz merged 3 commits intoweb-infra-dev:mainfrom Feb 5, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
CodSpeed Performance ReportMerging #9159 will not alter performanceComparing 🎉 Hooray!
|
jerrykingxyz
approved these changes
Feb 5, 2025
This was referenced Mar 6, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rspack persistent cache depends on inventory v0.1. But it supports wasm in v0.3. The main barrier to upgrade is https://github.com/dtolnay/inventory/releases/tag/0.2.0. So this pr makes the following changes:
inventory!withconst.__DYN_IDwithxxhash-rust, which supports calculating hash in const context(compile time). I think this also improves the performance.VTablePtrstruct withSendandSyncrather thanusize, and useunsafeto guarantee the safety. The reason is that transmuting a vtable address tousizeis not permitted by rustc since it is unknown in compile time.This pr does not mean there is no other problem to use persistent cache in wasm. But at least it's something beneficial.
Checklist