Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get resolved module #8906

Merged
merged 5 commits into from
Jan 2, 2025
Merged

fix: get resolved module #8906

merged 5 commits into from
Jan 2, 2025

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 31, 2024

Summary

moduleGraph.getResolvedModule(dependency) is used to access the module that is constructed through the dependency during the build phase.

moduleGraph.getModule(dependency) is utilized to access the module corresponding to the dependency in the current module graph. For instance, during the processAssets phase, the concatenateModules optimization is performed, and multiple dependencies might point to the same concatenated module.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 31, 2024
Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 5ccf8e7
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6773bf270815e20008d73643

Copy link

codspeed-hq bot commented Dec 31, 2024

CodSpeed Performance Report

Merging #8906 will not alter performance

Comparing fix-get-resolved-module (5ccf8e7) with main (c2d74d5)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@SyMind SyMind marked this pull request as ready for review December 31, 2024 09:25
@SyMind SyMind force-pushed the fix-get-resolved-module branch from 0e7ce8f to d85529b Compare December 31, 2024 09:33
JSerFeng
JSerFeng previously approved these changes Dec 31, 2024
@SyMind SyMind merged commit 46e8278 into main Jan 2, 2025
32 checks passed
@SyMind SyMind deleted the fix-get-resolved-module branch January 2, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants