Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change javascript parser options in child compiler #7812

Merged

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Sep 5, 2024

Summary

fix web-infra-dev/rsbuild#3353

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from chenjiahan September 5, 2024 12:20
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 5, 2024
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 8420e79
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66deba2bcadbfe000868e94a
😎 Deploy Preview https://deploy-preview-7812--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahabhgk ahabhgk enabled auto-merge (squash) September 5, 2024 12:20
chenjiahan
chenjiahan previously approved these changes Sep 5, 2024
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ahabhgk ahabhgk force-pushed the fix-change-javascript-parser-options-in-child-compiler branch from c6f59ec to 8420e79 Compare September 9, 2024 09:04
@ahabhgk ahabhgk merged commit 500c045 into main Sep 9, 2024
28 checks passed
@ahabhgk ahabhgk deleted the fix-change-javascript-parser-options-in-child-compiler branch September 9, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid URL error thrown when using html-loader
2 participants