Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use itoa for integer to string conversion #7762

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

shulaoda
Copy link
Collaborator

@shulaoda shulaoda commented Sep 2, 2024

Summary

Related to rolldown/rolldown#2107

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Sep 2, 2024
@shulaoda
Copy link
Collaborator Author

shulaoda commented Sep 2, 2024

@chenjiahan cc

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit ac7995b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66d7058d20a8ad0008689f67

@chenjiahan
Copy link
Member

Nice 👍

@chenjiahan
Copy link
Member

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 2, 2024

📝 Benchmark detail: Open

Name Base (2024-09-02 7b13eac) Current Change
10000_development-mode + exec 2.23 s ± 32 ms 2.24 s ± 42 ms +0.13 %
10000_development-mode_hmr + exec 692 ms ± 21 ms 695 ms ± 13 ms +0.54 %
10000_production-mode + exec 2.85 s ± 30 ms 2.82 s ± 27 ms -0.95 %
arco-pro_development-mode + exec 1.86 s ± 57 ms 1.89 s ± 76 ms +1.42 %
arco-pro_development-mode_hmr + exec 435 ms ± 3.5 ms 436 ms ± 2.6 ms +0.15 %
arco-pro_production-mode + exec 3.27 s ± 89 ms 3.27 s ± 69 ms +0.08 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.35 s ± 85 ms 3.35 s ± 51 ms 0.00 %
threejs_development-mode_10x + exec 1.66 s ± 18 ms 1.66 s ± 21 ms -0.32 %
threejs_development-mode_10x_hmr + exec 806 ms ± 13 ms 805 ms ± 6.5 ms -0.10 %
threejs_production-mode_10x + exec 5.17 s ± 19 ms 5.16 s ± 33 ms -0.14 %

@shulaoda shulaoda requested a review from ahabhgk September 3, 2024 08:42
Cargo.toml Outdated Show resolved Hide resolved
crates/rspack_macros/src/merge.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahabhgk ahabhgk enabled auto-merge (squash) September 3, 2024 12:51
@ahabhgk ahabhgk merged commit cd962e5 into web-infra-dev:main Sep 3, 2024
28 checks passed
@shulaoda shulaoda deleted the perf/use-itoa branch September 3, 2024 13:19
@chenjiahan chenjiahan mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants