feat(rspack_core): dump swc ast with ctxt #742
Merged
IWANABETHATGUY merged 3 commits intonextfrom Sep 19, 2022
Merged
Conversation
IWANABETHATGUY
commented
Sep 16, 2022
| }b /*#1*/ ; | ||
| // err = 3; | ||
| let a /*#1*/ = 10; | ||
| function another() { |
Contributor
Author
There was a problem hiding this comment.
Notice that another is not dumped correctly, the identifier should have #1 ctxt, this is a bug of swc codegen .
IWANABETHATGUY
changed the title
h-a-n-a
approved these changes
Sep 16, 2022
| GLOBALS.set(global, || { | ||
| module.visit_mut_with(&mut resolver(Mark::new(), Mark::new(), false)); | ||
| let mut noop = Noop { | ||
| trailing: comment.trailing.clone(), |
Contributor
There was a problem hiding this comment.
LGTM, but I think the code could be much cleaner if SwcComments was passed directly, thus, it's not necessary for us to introduce crate ahash .
Contributor
Author
There was a problem hiding this comment.
sounds great
Contributor
|
It could be even cleaner with trait |
Contributor
Author
|
I review the |
Contributor
Author
|
It is mainly used in debugging, will change it if we need the scaleability |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Related issue (if exists)
Further reading