Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: clean node_modules and target #7299

Merged
merged 5 commits into from
Sep 5, 2024
Merged

ci: clean node_modules and target #7299

merged 5 commits into from
Sep 5, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Jul 24, 2024 •
edited
Loading

Summary

Clean node_modules and target directories to prevent them from growing too large.

  1. On Windows, use powershell to check the directory creation time since the du command is very slow.
  2. On Linux and macOS, continue using the du command to check directory size.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jul 24, 2024
@SyMind SyMind force-pushed the clean-node-modules-and-target branch 6 times, most recently from a03ffbb to 052a538 Compare July 24, 2024 12:34
@SyMind SyMind force-pushed the clean-node-modules-and-target branch from 052a538 to f6549d4 Compare July 24, 2024 12:36
@SyMind SyMind marked this pull request as ready for review July 25, 2024 03:08
@SyMind SyMind requested a review from jerrykingxyz as a code owner July 25, 2024 03:08
@netlify Netlify
Copy link

netlify bot commented Sep 4, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8e31d60
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66d9a13e07e5b300083c1dce

@SyMind SyMind force-pushed the clean-node-modules-and-target branch from a18b6d0 to 1214592 Compare September 4, 2024 12:23
@SyMind SyMind force-pushed the clean-node-modules-and-target branch from 6e71ced to 8e31d60 Compare September 5, 2024 12:17
@SyMind SyMind merged commit dbc5223 into main Sep 5, 2024
51 of 52 checks passed
@SyMind SyMind deleted the clean-node-modules-and-target branch September 5, 2024 12:43
SyMind added a commit that referenced this pull request Sep 5, 2024
@SyMind
Revert "ci: clean node_modules and target (#7299)"
c803535 
This reverts commit dbc5223.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrykingxyz jerrykingxyz jerrykingxyz approved these changes

Assignees

@SyMind SyMind

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SyMind @jerrykingxyz