Skip to content

ci: build linux debug binary directly for CI purpose to speedup PR check #7243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

xc2
Copy link
Collaborator

@xc2 xc2 commented Jul 20, 2024

Summary

Build linux debug binary directly instead of on another container

Applied for:

  1. github shared runner only
  2. the CI Workflow only
  3. Test Linux job only that is typically run test for PR

Will reduce the execute time of build step of Test Linux / Build from >7m to ~5m - typically from image pull and toolchain download.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 20, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 4ea59b4
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67444993a05a9800080fb390

@xc2 xc2 changed the title ci(CI): build debug binary directly instead of on docker when run on github shared runner ci: build debug binary directly instead of on docker when run on github shared runner Jul 20, 2024
@xc2 xc2 changed the title ci: build debug binary directly instead of on docker when run on github shared runner ci: build linux debug binary directly for CI purpose to speedup PR check Jul 20, 2024
@xc2 xc2 marked this pull request as ready for review July 20, 2024 12:19
@xc2 xc2 requested a review from jerrykingxyz as a code owner July 20, 2024 12:19
@xc2 xc2 force-pushed the ci-native-build-for-test branch from 12508e5 to bb91671 Compare July 21, 2024 07:30
@chenjiahan chenjiahan requested a review from jerrykingxyz August 6, 2024 03:28
Copy link

stale bot commented Oct 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump").

@stale stale bot added the stale label Oct 5, 2024
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #7243 will not alter performance

Comparing xc2:ci-native-build-for-test (4ea59b4) with main (cee7307)

Summary

✅ 1 untouched benchmarks

@stale stale bot removed the stale label Dec 10, 2024
@jerrykingxyz jerrykingxyz merged commit dfb1734 into web-infra-dev:main Dec 17, 2024
32 checks passed
@chenjiahan
Copy link
Member

Thanks ❤️

@h-a-n-a h-a-n-a mentioned this pull request Dec 19, 2024
2 tasks
@xc2 xc2 deleted the ci-native-build-for-test branch January 21, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants