Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zod is pre-bundled twice #7064

Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix: zod is pre-bundled twice #7064

merged 1 commit into from
Jul 8, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Fix zod is pre-bundled twice because we do not configure externals for zod-validation-error correctly.

compiled/zod-validation-error/index.js: from 157kb to 8kb.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Jul 7, 2024
Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 6ca23e4
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/668a896ab9b7570008ffb0ab

@chenjiahan chenjiahan requested a review from SyMind July 7, 2024 12:27
@chenjiahan chenjiahan merged commit e5dced0 into main Jul 8, 2024
34 checks passed
@chenjiahan chenjiahan deleted the zod_duplicated_0707 branch July 8, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants