Skip to content

feat: definePlugin helper #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerrykingxyz merged 6 commits into from
Mar 23, 2023
Merged

feat: definePlugin helper #2302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68b6d02
feat: add definePlugin
so1ve Mar 16, 2023
3a9e1e6
chore: changeset
so1ve Mar 16, 2023
cb2f425
fix: export helper
so1ve Mar 16, 2023
a6d183a
Merge branch 'main' into feat/define-plugin
so1ve Mar 21, 2023
8cc4acb
Merge branch 'main' into feat/define-plugin
so1ve Mar 22, 2023
0a58a33
Merge branch 'main' into feat/define-plugin
so1ve Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-yaks-tan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rspack/cli": patch
---

add definePlugin helper
2 changes: 1 addition & 1 deletion packages/rspack-cli/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export * from "./types";
export { RspackCLI, defineConfig } from "./rspack-cli";
export { RspackCLI, defineConfig, definePlugin } from "./rspack-cli";
8 changes: 8 additions & 0 deletions packages/rspack-cli/src/rspack-cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
import { normalizeEnv } from "./utils/options";
import { loadRspackConfig } from "./utils/loadConfig";
import { Mode } from "@rspack/core/src/config";
import { RspackPluginInstance, RspackPluginFunction } from "@rspack/core";

type RspackEnv = "development" | "production";
export class RspackCLI {
Expand Down Expand Up @@ -252,3 +253,10 @@ export class RspackCLI {
export function defineConfig(config: RspackOptions): RspackOptions {
return config;
}

// Note: use union type will make apply function's `compiler` type to be `any`
export function definePlugin(plugin: RspackPluginFunction): RspackPluginFunction
export function definePlugin(plugin: RspackPluginInstance): RspackPluginInstance
export function definePlugin(plugin: any): any {
return plugin;
}