chore: update rust toolchain from nightly-2025-11-13 to nightly-2026-04-16#13723
Merged
chore: update rust toolchain from nightly-2025-11-13 to nightly-2026-04-16#13723
Conversation
github-actions
Bot
added
the
team
Contributor
📦 Binary Size-limit
🎉 Size decreased by 768.84KB from 49.39MB to 48.64MB (⬇️1.52%) |
Contributor
Rsdoctor Bundle Diff AnalysisFound 6 projects in monorepo, 6 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 popular-libsPath:
📁 react-10kPath:
📁 react-1kPath:
📁 romePath:
📁 react-5kPath:
📁 ui-componentsPath:
Generated by Rsdoctor GitHub Action |
Merging this PR will degrade performance by 2.13%
Performance Changes
Comparing 
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Rust nightly toolchain and applies clippy-motivated refactors across multiple crates, including a binding-layer change to how Dependency trait-object pointers are stored for N-API interop.
Changes:
- Bump Rust toolchain from
nightly-2025-11-13tonightly-2026-04-16. - Apply clippy-driven refactors (e.g.
while letloops,sort_by_key, iterator simplifications) across core/plugins/tools. - Adjust
rspack_binding_apidependency wrapper pointer handling to satisfy new nightly lifetime/trait-object constraints.
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Update pinned nightly toolchain version. |
| crates/rspack_tools/src/compare/mod.rs | Simplify queue loop with while let. |
| crates/rspack_plugin_runtime/src/runtime_plugin.rs | Add clippy lint suppression. |
| crates/rspack_plugin_real_content_hash/src/lib.rs | Simplify loop with while let. |
| crates/rspack_plugin_mf/src/manifest/mod.rs | Remove redundant into_iter() in extend. |
| crates/rspack_plugin_json/src/utils.rs | Use sort_unstable_by_key for clarity. |
| crates/rspack_plugin_javascript/src/plugin/module_concatenation_plugin.rs | Deterministic sorting using Reverse key. |
| crates/rspack_plugin_javascript/src/parser_plugin/side_effects_parser_plugin.rs | Add clippy lint suppressions. |
| crates/rspack_plugin_javascript/src/parser_plugin/const/if_stmt.rs | Add clippy lint suppression. |
| crates/rspack_plugin_javascript/src/dependency/esm/esm_import_dependency.rs | Add clippy lint suppression. |
| crates/rspack_plugin_extract_css/src/runtime.rs | Use sort_unstable_by_key for attribute ordering. |
| crates/rspack_plugin_esm_library/src/render.rs | Use sort_by_key for deterministic ordering. |
| crates/rspack_plugin_esm_library/src/plugin.rs | Use sort_by_key for deterministic ordering. |
| crates/rspack_plugin_esm_library/src/optimize_chunks.rs | Deterministic ordering via sort_by_key. |
| crates/rspack_plugin_esm_library/src/link.rs | Iterate map values directly instead of tuple destructuring. |
| crates/rspack_plugin_css_chunking/src/lib.rs | Simplify module processing loop with while let. |
| crates/rspack_plugin_css/src/parser_and_generator/mod.rs | Remove redundant iterator conversion in zip. |
| crates/rspack_plugin_copy/src/lib.rs | Use sort_unstable_by_key for determinism. |
| crates/rspack_loader_swc/src/rsc_transforms/server_actions.rs | Add clippy suppressions and simplify pattern matching. |
| crates/rspack_core/src/utils/find_graph_roots.rs | Use sort_by_key for deterministic ordering. |
| crates/rspack_core/src/utils/extract_source_map.rs | Avoid redundant into_iter() in zip. |
| crates/rspack_core/src/external_module.rs | Add clippy lint suppression. |
| crates/rspack_core/src/context_module_factory.rs | Use is_ok_and for metadata directory checks. |
| crates/rspack_core/src/concatenated_module.rs | Use sort_unstable_by_key for ordering. |
| crates/rspack_core/src/compiler/mod.rs | Simplify clean-up iteration over emitted asset keys. |
| crates/rspack_core/src/compilation/build_module_graph/graph_updater/cutout/fix_issuers.rs | Simplify queue loops with while let. |
| crates/rspack_core/src/cache/persistent/build_dependencies/mod.rs | Simplify queue loop with while let. |
| crates/rspack_binding_api/src/dependency.rs | Change dependency pointer storage approach to satisfy new lifetime constraints. |
| crates/rspack_binding_api/src/chunk.rs | Use sort_unstable_by_key for deterministic ordering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
📝 Benchmark detail: Open
|
quininer
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code updates:
crates/rspack_binding_api/src/dependency.rs: refers to Remove object lifetime cast metrics-rs/metrics#564Checklist