chore: enable fair sched for codspeed#12798
Conversation
Deploying rspack-v2 with
|
| Latest commit: |
aba24cb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://97faf5e8.rspack-v2.pages.dev |
| Branch Preview URL: | https://01-21-chore-fair-lock.rspack-v2.pages.dev |
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Pull request overview
This PR switches from using the official CodSpeed GitHub Action to a local custom action implementation to enable the --fair-sched=yes flag for Valgrind, aiming to stabilize benchmark results. The change is a partial revert of PR #12763.
Changes:
- Replaces the official CodSpeed action with a local custom action
- Adds fair scheduling support via VALGRIND_FLAGS environment variable
- Uses a forked runner from CPunisher/runner with valgrind configuration support
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| .github/workflows/reusable-build-bench.yml | Updates the benchmark workflow to use the new local CodSpeed action instead of the official action |
| .github/actions/codspeed/action.yaml | Adds a new custom CodSpeed action that installs a forked runner and enables fair scheduling for benchmarks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🙈 Size remains the same at 47.99MB |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Summary
It's seems that the codspeed goes very unstable after #12763, so revert part of it.
Checklist