Skip to content

chore: enable fair sched for codspeed#12798

Merged
stormslowly merged 3 commits intomainfrom
01-21-chore/fair-lock
Jan 21, 2026
Merged

chore: enable fair sched for codspeed#12798
stormslowly merged 3 commits intomainfrom
01-21-chore/fair-lock

Conversation

@CPunisher
Copy link
Contributor

@CPunisher CPunisher commented Jan 21, 2026

Summary

It's seems that the codspeed goes very unstable after #12763, so revert part of it.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 21, 2026 03:44
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2026

Deploying rspack-v2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: aba24cb
Status: ✅  Deploy successful!
Preview URL: https://97faf5e8.rspack-v2.pages.dev
Branch Preview URL: https://01-21-chore-fair-lock.rspack-v2.pages.dev

View logs

@netlify
Copy link

netlify bot commented Jan 21, 2026

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit aba24cb
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/69705404d9671c00089c19e5

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR switches from using the official CodSpeed GitHub Action to a local custom action implementation to enable the --fair-sched=yes flag for Valgrind, aiming to stabilize benchmark results. The change is a partial revert of PR #12763.

Changes:

  • Replaces the official CodSpeed action with a local custom action
  • Adds fair scheduling support via VALGRIND_FLAGS environment variable
  • Uses a forked runner from CPunisher/runner with valgrind configuration support

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

File Description
.github/workflows/reusable-build-bench.yml Updates the benchmark workflow to use the new local CodSpeed action instead of the official action
.github/actions/codspeed/action.yaml Adds a new custom CodSpeed action that installs a forked runner and enables fair scheduling for benchmarks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 825.4 KB 0
react-5k 2.7 MB 0
rome 984.2 KB 0
ui-components 2.1 MB 0

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

📦 Binary Size-limit

Comparing aba24cb to fix: require.resolve() replaced as require() (#12773) by intellild

🙈 Size remains the same at 47.99MB

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing 01-21-chore/fair-lock (aba24cb) with main (48885c7)

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@stormslowly stormslowly merged commit 0984824 into main Jan 21, 2026
78 of 80 checks passed
@stormslowly stormslowly deleted the 01-21-chore/fair-lock branch January 21, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants