Skip to content

Conversation

@LingyuCoder
Copy link
Contributor

Summary

This PR changes the default value of output.hotUpdateGlobal from webpackHotUpdate to rspackHotUpdate. This change helps differentiate Rspack's HMR runtime from webpack's, making it clearer which bundler is being used when inspecting the global scope during development.

This is a breaking change for users who rely on the default hotUpdateGlobal value, but it aligns with Rspack's branding and avoids potential conflicts when both webpack and Rspack are used in the same environment.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jan 19, 2026

Deploy Preview for rspack-v2 canceled.

Name Link
🔨 Latest commit 4b26937
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/696dac5ea4a748000898c61e

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 19, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

📦 Binary Size-limit

Comparing 4b26937 to fix(browser): update worker format and add e2e test (#12747) by CPunisher

🎉 Size decreased by 324.63KB from 47.99MB to 47.68MB (⬇️0.66%)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -37.0 B (-0.0%)
react-1k 825.3 KB -29.0 B (-0.0%)
react-5k 2.7 MB -28.0 B (-0.0%)
rome 985.8 KB +1.7 KB (0.2%)
ui-components 2.1 MB -30.0 B (-0.0%)
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 5b35090e32 | PR: #12747

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -37.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -37.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 5b35090e32 | PR: #12747

Metric Current Baseline Change
📊 Total Size 825.3 KB 825.4 KB -29.0 B (-0.0%)
📄 JavaScript 825.3 KB 825.4 KB -29.0 B (-0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 5b35090e32 | PR: #12747

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB -28.0 B (-0.0%)
📄 JavaScript 2.7 MB 2.7 MB -28.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 5b35090e32 | PR: #12747

Metric Current Baseline Change
📊 Total Size 985.8 KB 984.2 KB +1.7 KB (0.2%)
📄 JavaScript 985.8 KB 984.2 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 5b35090e32 | PR: #12747

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB -30.0 B (-0.0%)
📄 JavaScript 2.0 MB 2.0 MB -30.0 B (-0.0%)
🎨 CSS 83.0 KB 83.0 KB 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@chenjiahan chenjiahan merged commit 095680c into v2 Jan 19, 2026
50 of 52 checks passed
@chenjiahan chenjiahan deleted the feat/use-rspack-hot-update-global branch January 19, 2026 05:00
@chenjiahan chenjiahan changed the title feat: use rspackHotUpdate as default hotUpdateGlobal feat!: use rspackHotUpdate as default hotUpdateGlobal Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants