Skip to content

feat!: default loader/plugin target by rspack target #12752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hardfist merged 4 commits into from
Jan 16, 2026
Merged

feat!: default loader/plugin target by rspack target #12752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d69255c
feat: default loader/plugin target by rspack target
ahabhgk Jan 15, 2026
498fe9e
fix
ahabhgk Jan 16, 2026
67aff3c
test
ahabhgk Jan 16, 2026
852d5b8
fix desc
ahabhgk Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions crates/node_binding/napi-binding.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2101,22 +2101,22 @@ export interface RawEntryDynamicResult {
}

export interface RawEnvironment {
const?: boolean
methodShorthand?: boolean
arrowFunction?: boolean
nodePrefixForCoreModules?: boolean
asyncFunction?: boolean
bigIntLiteral?: boolean
destructuring?: boolean
document?: boolean
dynamicImport?: boolean
forOf?: boolean
globalThis?: boolean
module?: boolean
optionalChaining?: boolean
templateLiteral?: boolean
dynamicImportInWorker?: boolean
importMetaDirnameAndFilename?: boolean
const: boolean
methodShorthand: boolean
arrowFunction: boolean
nodePrefixForCoreModules: boolean
asyncFunction: boolean
bigIntLiteral: boolean
destructuring: boolean
document: boolean
dynamicImport: boolean
forOf: boolean
globalThis: boolean
module: boolean
optionalChaining: boolean
templateLiteral: boolean
dynamicImportInWorker: boolean
importMetaDirnameAndFilename: boolean
}

export interface RawEsmLibraryPlugin {
Expand Down Expand Up @@ -2406,7 +2406,7 @@ export interface RawLightningCssBrowsers {

export interface RawLightningCssMinimizerOptions {
errorRecovery: boolean
targets?: Array<string>
targets?: string[] | RawLightningCssBrowsers
include?: number
exclude?: number
drafts?: RawDraft
Expand Down
55 changes: 38 additions & 17 deletions crates/rspack/src/builder/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3078,23 +3078,44 @@ impl OutputOptionsBuilder {
}

let mut environment = f!(self.environment.take(), Environment::default);
environment.global_this = tp.and_then(|t| t.global_this);
environment.big_int_literal = tp.map(|t| optimistic!(t.big_int_literal));
environment.r#const = tp.map(|t| optimistic!(t.r#const));
environment.arrow_function = tp.map(|t| optimistic!(t.arrow_function));
environment.async_function = tp.map(|t| optimistic!(t.async_function));
environment.for_of = tp.map(|t| optimistic!(t.for_of));
environment.destructuring = tp.map(|t| optimistic!(t.destructuring));
environment.optional_chaining = tp.map(|t| optimistic!(t.optional_chaining));
environment.node_prefix_for_core_modules =
tp.map(|t| optimistic!(t.node_prefix_for_core_modules));
environment.template_literal = tp.map(|t| optimistic!(t.template_literal));
environment.dynamic_import =
tp.map(|t| conditionally_optimistic!(t.dynamic_import, output_module));
environment.dynamic_import_in_worker =
tp.map(|t| conditionally_optimistic!(t.dynamic_import_in_worker, output_module));
environment.module = tp.map(|t| conditionally_optimistic!(t.module, output_module));
environment.document = tp.map(|t| optimistic!(t.document));
environment.global_this = tp.and_then(|t| t.global_this).unwrap_or_default();
environment.big_int_literal = tp
.map(|t| optimistic!(t.big_int_literal))
.unwrap_or_default();
environment.r#const = tp.map(|t| optimistic!(t.r#const)).unwrap_or_default();
environment.method_shorthand = tp
.map(|t| optimistic!(t.method_shorthand))
.unwrap_or_default();
environment.arrow_function = tp
.map(|t| optimistic!(t.arrow_function))
.unwrap_or_default();
environment.async_function = tp
.map(|t| optimistic!(t.async_function))
.unwrap_or_default();
environment.for_of = tp.map(|t| optimistic!(t.for_of)).unwrap_or_default();
environment.destructuring = tp.map(|t| optimistic!(t.destructuring)).unwrap_or_default();
environment.optional_chaining = tp
.map(|t| optimistic!(t.optional_chaining))
.unwrap_or_default();
environment.node_prefix_for_core_modules = tp
.map(|t| optimistic!(t.node_prefix_for_core_modules))
.unwrap_or_default();
environment.import_meta_dirname_and_filename = tp
.and_then(|t| t.import_meta_dirname_and_filename)
.unwrap_or_default();
environment.template_literal = tp
.map(|t| optimistic!(t.template_literal))
.unwrap_or_default();
environment.dynamic_import = tp
.map(|t| conditionally_optimistic!(t.dynamic_import, output_module))
.unwrap_or_default();
environment.dynamic_import_in_worker = tp
.map(|t| conditionally_optimistic!(t.dynamic_import_in_worker, output_module))
.unwrap_or_default();
environment.module = tp
.map(|t| conditionally_optimistic!(t.module, output_module))
.unwrap_or_default();
environment.document = tp.map(|t| optimistic!(t.document)).unwrap_or_default();

Ok(OutputOptions {
path,
Expand Down
Loading
Loading