-
-
Notifications
You must be signed in to change notification settings - Fork 760
feat!: Rspack off modules and assets in normal stats #12701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.
|
733c589 to
a74aaa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR changes the default values for stats.modules and stats.chunkModules from true to false (unless all === true) to reduce JS-Rust communication overhead. This is a breaking change that diverges from webpack's default behavior.
Changes:
- Simplified
chunkModulesdefault from a complex conditional function toNORMAL_OFF - Simplified
modulesdefault from a complex conditional function toNORMAL_OFF - Added explanatory comments noting the divergence from webpack's defaults
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 3 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 react-10kPath:
📦 Download Diff Report: react-10k Bundle Diff 📁 react-5kPath:
📦 Download Diff Report: react-5k Bundle Diff 📁 romePath:
📦 Download Diff Report: rome Bundle Diff Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🎉 Size decreased by 343.38KB from 47.99MB to 47.66MB (⬇️0.70%) |
Merging this PR will not alter performance
Comparing Footnotes
|
a74aaa7 to
009656b
Compare
✅ Deploy Preview for rspack-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ea7de1c to
009656b
Compare
d8e2e8b to
bbddae3
Compare
bbddae3 to
21c58bb
Compare
47661e3 to
72d8a67
Compare
6869e51 to
7cbe5eb
Compare
38ee695 to
0f1f048
Compare
0f1f048 to
28f2ed7
Compare
a4587f7 to
c495835
Compare
Summary
This PR changes the default values for
stats.modulesandstats.chunksfrom true to false (unless all === true) to reduce JS-Rust communication overhead. This is a breaking change that diverges from webpack's default behavior.Related links
Checklist