Skip to content

fix(test): flaky test due to calling toJSON while hot updating #12694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stormslowly merged 1 commit into from
Jan 12, 2026
Merged

fix(test): flaky test due to calling toJSON while hot updating #12694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tests/e2e/cases/make/remove-dynamic-entry-with-loader/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@ test('should compile', async ({ page, fileAction, rspack }) => {
),
);

await expect(async () => {
await page.reload();
expect(await page.locator('#index1').innerText()).toBe('index1 updated');
}).toPass();
await expect(page.locator('#index1')).toContainText('index1 updated');

await expect(page.locator('#index2')).toHaveCount(0);
await expect(page.locator('#webpack-dev-server-client-overlay')).toHaveCount(
Expand Down
3 changes: 3 additions & 0 deletions tests/e2e/cases/make/remove-dynamic-entry-with-loader/rspack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ module.exports = {
},
context: __dirname,
mode: 'development',
optimization: {
runtimeChunk: 'single',
},
plugins: [
new rspack.HtmlRspackPlugin(),
function (compiler) {
Expand Down
Loading