feat(@rspack-cli): make @rspack/dev-server and webpack-bundle-analyzer peer dependencies #12682
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -34,13 +34,12 @@ | |||||||
| }, | ||||||||
| "dependencies": { | ||||||||
| "@discoveryjs/json-ext": "^0.5.7", | ||||||||
| "exit-hook": "^4.0.0" | ||||||||
| }, | ||||||||
| "devDependencies": { | ||||||||
| "@rslib/core": "0.19.1", | ||||||||
| "@rspack/core": "workspace:*", | ||||||||
| "@rspack/dev-server": "~1.1.5", | ||||||||
| "@rspack/test-tools": "workspace:*", | ||||||||
| "@types/webpack-bundle-analyzer": "^4.7.0", | ||||||||
| "cac": "^6.7.14", | ||||||||
|
|
@@ -50,10 +49,24 @@ | |||||||
| "picocolors": "^1.1.1", | ||||||||
| "pirates": "^4.0.7", | ||||||||
| "ts-node": "^10.9.2", | ||||||||
| "typescript": "^5.9.3", | ||||||||
| "webpack-bundle-analyzer": "4.10.2" | ||||||||
| }, | ||||||||
| "peerDependencies": { | ||||||||
| "@rspack/core": "^1.0.0-alpha || ^1.x", | ||||||||
| "@rspack/dev-server": "~1.1.5", | ||||||||
| "webpack-bundle-analyzer": "4.10.2" | ||||||||
| }, | ||||||||
| "peerDependenciesMeta": { | ||||||||
| "@rspack/core": { | ||||||||
| "optional": false | ||||||||
| }, | ||||||||
|
Comment on lines
+61
to
+63
Author
There was a problem hiding this comment.
Comment on lines
+61
to
+63
There was a problem hiding this comment. Setting "optional": false for @rspack/core in peerDependenciesMeta is redundant, as peer dependencies are required by default. You can remove this entry and only keep the entries for optional peer dependencies (@rspack/dev-server and webpack-bundle-analyzer).
Suggested change
|
||||||||
| "@rspack/dev-server": { | ||||||||
| "optional": true | ||||||||
| }, | ||||||||
| "webpack-bundle-analyzer": { | ||||||||
| "optional": true | ||||||||
| } | ||||||||
| }, | ||||||||
| "publishConfig": { | ||||||||
| "access": "public", | ||||||||
|
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -40,6 +40,18 @@ export class PreviewCommand implements RspackCommand { | |||||
| setDefaultNodeEnv(options, 'production'); | ||||||
| normalizeCommonOptions(options, 'preview'); | ||||||
|
|
||||||
| const packageName = '@rspack/dev-server'; | ||||||
| try { | ||||||
| require.resolve(packageName); | ||||||
| } catch { | ||||||
| const logger = cli.getLogger(); | ||||||
| logger.warn( | ||||||
|
There was a problem hiding this comment. The error message uses logger.warn but then exits with code 2, which indicates an error. Consider using logger.error instead of logger.warn for consistency, since this is a fatal error that prevents the command from running.
Suggested change
|
||||||
| `Package "${packageName}" is not installed. Please install it before using "rspack preview" command.`, | ||||||
| ); | ||||||
| process.exit(2); | ||||||
| } | ||||||
|
|
||||||
| // Lazy import @rspack/dev-server to avoid loading it on build mode | ||||||
| const { RspackDevServer } = await import('@rspack/dev-server'); | ||||||
|
|
||||||
| let { config } = await cli.loadConfig(options); | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -48,6 +48,17 @@ export class ServeCommand implements RspackCommand { | |||||
| normalizeCommonOptions(cliOptions, 'serve'); | ||||||
| cliOptions.hot = normalizeHotOption(cliOptions.hot); | ||||||
|
|
||||||
| const packageName = '@rspack/dev-server'; | ||||||
| try { | ||||||
| require.resolve(packageName); | ||||||
| } catch { | ||||||
| const logger = cli.getLogger(); | ||||||
| logger.warn( | ||||||
|
There was a problem hiding this comment. The error message uses logger.warn but then exits with code 2, which indicates an error. Consider using logger.error instead of logger.warn for consistency, since this is a fatal error that prevents the command from running.
Suggested change
|
||||||
| `Package "${packageName}" is not installed. Please install it before using "rspack serve" command.`, | ||||||
| ); | ||||||
| process.exit(2); | ||||||
| } | ||||||
|
|
||||||
| // Lazy import @rspack/dev-server to avoid loading it on build mode | ||||||
| const { RspackDevServer } = await import('@rspack/dev-server'); | ||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version constraint for webpack-bundle-analyzer in peerDependencies uses an exact version (4.10.2) which is overly restrictive. Consider using a more flexible version range like "^4.10.2" to allow users to use newer compatible versions without peer dependency warnings. This follows the pattern used for @rspack/core which uses "^1.0.0-alpha || ^1.x".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous contraint was fixed to
4.10.2, IMHO there is nothing to change here.