Skip to content

perf(deps)!: mark mf runtime tools as optional dependency#12663

Merged
ahabhgk merged 6 commits intov2from
remove-mf-runtime
Jan 8, 2026
Merged

perf(deps)!: mark mf runtime tools as optional dependency#12663
ahabhgk merged 6 commits intov2from
remove-mf-runtime

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Jan 7, 2026

Summary

Remove dependency @module-federation/runtime-tools, mark it as peer dependency instead

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from hardfist as a code owner January 7, 2026 11:34
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 7, 2026
@ahabhgk ahabhgk requested a review from LingyuCoder January 7, 2026 11:43
@ahabhgk ahabhgk changed the title chore!: remove mf runtime tools as optional dependency chore!: mark mf runtime tools as optional dependency Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 825.4 KB 0
react-5k 2.7 MB 0
rome 984.3 KB 0
ui-components 2.1 MB 0

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

📦 Binary Size-limit

Comparing c1c9f33 to fix(lint): enable @typescript-eslint/require-await rule (#12664) by Tu Shaokun

🎉 Size decreased by 30.88KB from 47.87MB to 47.84MB (⬇️0.06%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

Merging this PR will not alter performance

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing remove-mf-runtime (c1c9f33) with main (4ecc5cb)2

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

  2. No successful run was found on v2 (907c01d) during the generation of this report, so main (4ecc5cb) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@netlify
Copy link

netlify bot commented Jan 8, 2026

Deploy Preview for rspack-v2 canceled.

Name Link
🔨 Latest commit c1c9f33
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/695f38e88613470008a5ba9d

@chenjiahan chenjiahan changed the title chore!: mark mf runtime tools as optional dependency perf(deps)!: mark mf runtime tools as optional dependency Jan 8, 2026
@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Jan 8, 2026
@ahabhgk ahabhgk requested a review from chenjiahan January 8, 2026 09:55
@ahabhgk ahabhgk enabled auto-merge (squash) January 8, 2026 09:55
@ahabhgk ahabhgk merged commit 10d30ed into v2 Jan 8, 2026
55 checks passed
@ahabhgk ahabhgk deleted the remove-mf-runtime branch January 8, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments