Skip to content

fix(lint): enable @typescript-eslint/await-thenable rule #12644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 2 commits into from
Jan 7, 2026
Merged

fix(lint): enable @typescript-eslint/await-thenable rule #12644

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
188d567
fix(lint): enable await-thenable rule and fix violation
tt-a1i Jan 6, 2026
875a76f
Update rslint.json
chenjiahan Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/rspack/src/exports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ export const experiments: Experiments = {
},
async cleanup() {
await JavaScriptTracer.cleanupJavaScriptTrace();
await syncTraceEvent(JavaScriptTracer.events);
syncTraceEvent(JavaScriptTracer.events);
cleanupGlobalTrace();
},
},
Expand Down
2 changes: 1 addition & 1 deletion rslint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@typescript-eslint/use-unknown-in-catch-callback-variable": "off",
"@typescript-eslint/require-await": "off",
"@typescript-eslint/switch-exhaustiveness-check": "off",
"@typescript-eslint/await-thenable": "off",
"@typescript-eslint/await-thenable": "error",
Comment thread
chenjiahan marked this conversation as resolved.
Outdated
"@typescript-eslint/return-await": "off",
"@typescript-eslint/non-nullable-type-assertion-style": "off",
"@typescript-eslint/no-misused-spread": "off",
Expand Down
Loading