Skip to content

fix: shebang should always in entry chunk#12585

Merged
JSerFeng merged 1 commit intomainfrom
fix/shebang
Dec 30, 2025
Merged

fix: shebang should always in entry chunk#12585
JSerFeng merged 1 commit intomainfrom
fix/shebang

Conversation

@JSerFeng
Copy link
Contributor

Summary

Should always render shebang in entry chunk.

Render directives in chunk which really contains the module

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 30, 2025 08:03
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Dec 30, 2025
@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 01f58f7
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/69538746ce4e1e0008369341

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 30, 2025
@github-actions
Copy link
Contributor

Rsdoctor Bundle Diff Analysis

⚠️ Note: The latest commit (2ecf0ec625) does not have baseline artifacts. Using commit 4a0f619226 for baseline comparison instead. If this seems incorrect, please wait a few minutes and try rerunning the workflow.

Found 5 projects in monorepo, 1 project with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 823.4 KB 0
react-5k 2.7 MB 0
ui-components 2.1 MB 0
rome 984.3 KB -23.0 B (-0.0%)
📋 Detailed Reports (Click to expand)

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 4a0f619226 | PR: #12582

Metric Current Baseline Change
📊 Total Size 984.3 KB 984.4 KB -23.0 B (-0.0%)
📄 JavaScript 984.3 KB 984.4 KB -23.0 B (-0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing 01f58f7 to chore: bump swc_core from 52.0.0 to 54.0.0 and swc_experimental from 0.3.5 to 0.4.0 (#12582) by CPunisher

❌ Size increased by 512bytes from 47.85MB to 47.85MB (⬆️0.00%)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 30, 2025

CodSpeed Performance Report

Merging #12585 will not alter performance

Comparing fix/shebang (01f58f7) with main (4a0f619)

Summary

✅ 16 untouched
⏩ 1 skipped1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@JSerFeng JSerFeng enabled auto-merge (squash) December 30, 2025 08:53
@JSerFeng JSerFeng merged commit 7922a9a into main Dec 30, 2025
62 checks passed
@JSerFeng JSerFeng deleted the fix/shebang branch December 30, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants