Skip to content

Comments

docs: remove HomeBackground and navTransparent hack#12224

Merged
chenjiahan merged 1 commit intomainfrom
syt/upgrade-rstack-doc-ui
Nov 18, 2025
Merged

docs: remove HomeBackground and navTransparent hack#12224
chenjiahan merged 1 commit intomainfrom
syt/upgrade-rstack-doc-ui

Conversation

@SoonIter
Copy link
Member

@SoonIter SoonIter commented Nov 18, 2025

Summary

docs: remove HomeBackground and navTransparent hack

Related links

rstackjs/rstack-doc-ui#55

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 18, 2025 04:34
@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit d1a5833
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/691bf73cab11c20008c4ce64
😎 Deploy Preview https://deploy-preview-12224--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added release: document release: document related release(mr only) team The issue/pr is created by the member of Rspack. labels Nov 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a workaround for transparent navigation on the home page by eliminating the HomeBackground component hack and upgrading the @rstack-dev/doc-ui package to version 1.12.0, which likely handles this functionality natively.

  • Removed the deprecated HomeBackground component import and usage with inline style override
  • Updated @rstack-dev/doc-ui from 1.11.0 to 1.12.0
  • Updated transitive dependencies (framer-motion and motion-dom) to align with the new doc-ui version

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
website/theme/pages/index.tsx Removed HomeBackground import and its usage with the transparent navigation hack
website/package.json Upgraded @rstack-dev/doc-ui to version 1.12.0
pnpm-lock.yaml Updated lockfile entries for @rstack-dev/doc-ui and its transitive dependencies (framer-motion, motion-dom)
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing d1a5833 to chore(deps): update dependency glob to v11.1.0 [security] (#12223) by renovate[bot]

🙈 Size remains the same at 47.46MB

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan chenjiahan enabled auto-merge (squash) November 18, 2025 04:58
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 18, 2025

CodSpeed Performance Report

Merging #12224 will not alter performance

Comparing syt/upgrade-rstack-doc-ui (d1a5833) with main (061307b)

Summary

✅ 17 untouched

@chenjiahan chenjiahan merged commit 848f76a into main Nov 18, 2025
58 checks passed
@chenjiahan chenjiahan deleted the syt/upgrade-rstack-doc-ui branch November 18, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: document release: document related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants