Skip to content

fix: properties of build meta should be optional when sending to dll plugin from javascript#12070

Merged
LingyuCoder merged 1 commit intomainfrom
fix/dll-plugin-build-meta
Nov 3, 2025
Merged

fix: properties of build meta should be optional when sending to dll plugin from javascript#12070
LingyuCoder merged 1 commit intomainfrom
fix/dll-plugin-build-meta

Conversation

@LingyuCoder
Copy link
Contributor

Summary

Properties of build meta should be optional when sending to dll plugin from javascript

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 3, 2025 10:41
@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 118510c
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/690886e17eb40200083c9934

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Nov 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables several previously disabled test cases by fixing underlying issues and updates the JsBuildMeta API to make fields optional. The main changes include:

  • Removed test filters that were blocking test execution for "build timeout", missing expectations, and other issues
  • Updated Rust API to make JsBuildMeta fields optional with proper default values
  • Changed "FIXME" comments to "TODO" for remaining unimplemented features
  • Made stylistic improvements (spacing in function declarations)

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/rspack-test/configCases/scope-hoisting/dll-plugin/test.filter.js Removed test filter to enable test execution
tests/rspack-test/configCases/scope-hoisting/dll-plugin/rspack.config.js Cleaned up imports and removed obsolete comments
tests/rspack-test/configCases/rule-set/simple-use-fn-array/test.filter.js Changed "FIXME" to "TODO" and clarified the message
tests/rspack-test/configCases/rule-set/oneOf/test.filter.js Removed test filter to enable test execution
tests/rspack-test/configCases/rule-set/oneOf/rspack.config.js Added CSS experiments config and TODO comment
tests/rspack-test/configCases/rule-set/custom/test.filter.js Removed test filter to enable test execution
tests/rspack-test/configCases/rule-set/custom/rspack.config.js Added ident field with explanation comment
tests/rspack-test/configCases/rule-set/compiler/test.filter.js Changed "FIXME" to "TODO" and clarified the message
tests/rspack-test/configCases/resolve-merging/override/test.filter.js Removed test filter to enable test execution
tests/rspack-test/configCases/resolve-merging/override/index.js Commented out assertions with TODO explanation
tests/rspack-test/configCases/require/module-require/test.filter.js Changed "FIXME" to "TODO" and clarified the message
tests/rspack-test/configCases/require/module-require/index.js Formatting improvements for function declarations
tests/rspack-test/configCases/parsing/optional/test.filter.js Changed "FIXME" to "TODO"
crates/rspack_binding_api/src/module.rs Made JsBuildMeta fields optional with proper defaults
crates/node_binding/napi-binding.d.ts Updated TypeScript definitions to reflect optional fields

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

📦 Binary Size-limit

Comparing 118510c to perf: rspack sources memory (#12038) by Cong-Cong Pan

🎉 Size decreased by 2.50KB from 47.86MB to 47.86MB (⬇️0.01%)

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 3, 2025

CodSpeed Performance Report

Merging #12070 will not alter performance

Comparing fix/dll-plugin-build-meta (118510c) with main (55c107d)

Summary

✅ 17 untouched

@LingyuCoder LingyuCoder enabled auto-merge (squash) November 3, 2025 11:02
@LingyuCoder LingyuCoder merged commit 2d78ee6 into main Nov 3, 2025
77 of 79 checks passed
@LingyuCoder LingyuCoder deleted the fix/dll-plugin-build-meta branch November 3, 2025 14:06
@h-a-n-a h-a-n-a mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants