fix: properties of build meta should be optional when sending to dll plugin from javascript#12070
Merged
LingyuCoder merged 1 commit intomainfrom Nov 3, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables several previously disabled test cases by fixing underlying issues and updates the JsBuildMeta API to make fields optional. The main changes include:
- Removed test filters that were blocking test execution for "build timeout", missing expectations, and other issues
- Updated Rust API to make
JsBuildMetafields optional with proper default values - Changed "FIXME" comments to "TODO" for remaining unimplemented features
- Made stylistic improvements (spacing in function declarations)
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/rspack-test/configCases/scope-hoisting/dll-plugin/test.filter.js | Removed test filter to enable test execution |
| tests/rspack-test/configCases/scope-hoisting/dll-plugin/rspack.config.js | Cleaned up imports and removed obsolete comments |
| tests/rspack-test/configCases/rule-set/simple-use-fn-array/test.filter.js | Changed "FIXME" to "TODO" and clarified the message |
| tests/rspack-test/configCases/rule-set/oneOf/test.filter.js | Removed test filter to enable test execution |
| tests/rspack-test/configCases/rule-set/oneOf/rspack.config.js | Added CSS experiments config and TODO comment |
| tests/rspack-test/configCases/rule-set/custom/test.filter.js | Removed test filter to enable test execution |
| tests/rspack-test/configCases/rule-set/custom/rspack.config.js | Added ident field with explanation comment |
| tests/rspack-test/configCases/rule-set/compiler/test.filter.js | Changed "FIXME" to "TODO" and clarified the message |
| tests/rspack-test/configCases/resolve-merging/override/test.filter.js | Removed test filter to enable test execution |
| tests/rspack-test/configCases/resolve-merging/override/index.js | Commented out assertions with TODO explanation |
| tests/rspack-test/configCases/require/module-require/test.filter.js | Changed "FIXME" to "TODO" and clarified the message |
| tests/rspack-test/configCases/require/module-require/index.js | Formatting improvements for function declarations |
| tests/rspack-test/configCases/parsing/optional/test.filter.js | Changed "FIXME" to "TODO" |
| crates/rspack_binding_api/src/module.rs | Made JsBuildMeta fields optional with proper defaults |
| crates/node_binding/napi-binding.d.ts | Updated TypeScript definitions to reflect optional fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
🎉 Size decreased by 2.50KB from 47.86MB to 47.86MB (⬇️0.01%) |
CodSpeed Performance ReportMerging #12070 will not alter performanceComparing Summary
|
stormslowly
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Properties of build meta should be optional when sending to dll plugin from javascript
Related links
Checklist