Skip to content

fix: should handle require ensure with error function #12054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LingyuCoder merged 4 commits into from
Nov 3, 2025
+6 −11
Merged

fix: should handle require ensure with error function #12054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca4f6e0
fix: should handle require ensure with error function
LingyuCoder Oct 31, 2025
1a8bf81
fix: should handle require ensure with error function
LingyuCoder Oct 31, 2025
997fd33
fix: should handle require ensure with error function
LingyuCoder Oct 31, 2025
1cd8ac0
fix: should handle require ensure with error function
LingyuCoder Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions ...ack_plugin_javascript/src/parser_plugin/require_ensure_dependencies_block_parse_plugin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,12 @@ impl JavascriptParserPlugin for RequireEnsureDependenciesBlockParserPlugin {
let chunk_name = match expr
.args
.get(3)
.or(error_expr.as_ref().and(None)) // !errorExpression
.or(expr.args.get(2))
.or_else(|| if error_expr.is_some() { None } else { expr.args.get(2) }) // !errorExpression
{
Some(arg) => {
let chunk_name_expr = parser.evaluate_expression(&arg.expr);
match chunk_name_expr.as_string() {
Some(chunk_name_expr) => Some(chunk_name_expr),
None => return None,
}
}
Some(arg) => match parser.evaluate_expression(&arg.expr).as_string() {
Some(chunk_name) => Some(chunk_name),
None => return None,
},
None => None,
};

Expand Down
1 change: 0 additions & 1 deletion tests/rspack-test/configCases/parsing/dead-code-elimination-require-ensure/test.filter.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion tests/rspack-test/configCases/parsing/dead-code-elimination/test.filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = () => "FIXME: build failed";
module.exports = () => "TODO: support parser.scope.terminated"
Loading