fix: get chunk filename with dependOn#12053
Merged
LingyuCoder merged 2 commits intomainfrom Oct 31, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several issues related to chunk filename generation and query parameter handling in rspack, enabling previously disabled tests that were marked with FIXME comments.
- Implements a new
get_runtime_chunk_dependent_chunks_iterablemethod to properly handle runtime chunk dependencies - Enables tests for loader query parameter handling and non-webpack require warnings
- Removes test fixtures that were duplicates or are now obsolete
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_core/src/chunk_graph/chunk_graph_chunk.rs | Adds new get_runtime_chunk_dependent_chunks_iterable method and updates import to include VecDeque |
| crates/rspack_plugin_runtime/src/runtime_module/get_chunk_filename.rs | Changes to use the new get_runtime_chunk_dependent_chunks_iterable method instead of get_chunk_entry_dependent_chunks_iterable |
| tests/rspack-test/configCases/node/issue-18409/test.filter.js | Removes test filter that was disabling this test case |
| tests/rspack-test/configCases/node/issue-18409-2/* | Removes duplicate test case directory entirely |
| tests/rspack-test/configCases/module/rspack-issue-4777/index.js | Enables previously commented-out test assertions for query parameter handling |
| tests/rspack-test/configCases/module/parser/index.js | Removes obsolete FIXME comment |
| tests/rspack-test/configCases/module/non-webpack-require-warning/warnings.js | Updates test expectations to reflect rspack behavior differences |
| tests/rspack-test/configCases/module/non-webpack-require-warning/test.filter.js | Removes test filter that was disabling this test case |
| tests/rspack-test/configCases/module/match-module-type/index.js | Removes obsolete FIXME comment |
| tests/rspack-test/configCases/module/issue-17014-webworker/test.filter.js | Removes test filter that was disabling this test case |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 5.88KB from 47.84MB to 47.85MB (⬆️0.01%) |
CodSpeed Performance ReportMerging #12053 will not alter performanceComparing Summary
|
stormslowly
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should get entry related depend on chunks in get chunk filename runtime module of runtime chunk.
Related links
Checklist