Skip to content

fix: get chunk filename with dependOn#12053

Merged
LingyuCoder merged 2 commits intomainfrom
fix/get-chunk-filename-dependon
Oct 31, 2025
Merged

fix: get chunk filename with dependOn#12053
LingyuCoder merged 2 commits intomainfrom
fix/get-chunk-filename-dependon

Conversation

@LingyuCoder
Copy link
Contributor

Summary

should get entry related depend on chunks in get chunk filename runtime module of runtime chunk.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 31, 2025 09:18
@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 110af6c
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/69047ee55d5e71000719e50f

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Oct 31, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several issues related to chunk filename generation and query parameter handling in rspack, enabling previously disabled tests that were marked with FIXME comments.

  • Implements a new get_runtime_chunk_dependent_chunks_iterable method to properly handle runtime chunk dependencies
  • Enables tests for loader query parameter handling and non-webpack require warnings
  • Removes test fixtures that were duplicates or are now obsolete

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/rspack_core/src/chunk_graph/chunk_graph_chunk.rs Adds new get_runtime_chunk_dependent_chunks_iterable method and updates import to include VecDeque
crates/rspack_plugin_runtime/src/runtime_module/get_chunk_filename.rs Changes to use the new get_runtime_chunk_dependent_chunks_iterable method instead of get_chunk_entry_dependent_chunks_iterable
tests/rspack-test/configCases/node/issue-18409/test.filter.js Removes test filter that was disabling this test case
tests/rspack-test/configCases/node/issue-18409-2/* Removes duplicate test case directory entirely
tests/rspack-test/configCases/module/rspack-issue-4777/index.js Enables previously commented-out test assertions for query parameter handling
tests/rspack-test/configCases/module/parser/index.js Removes obsolete FIXME comment
tests/rspack-test/configCases/module/non-webpack-require-warning/warnings.js Updates test expectations to reflect rspack behavior differences
tests/rspack-test/configCases/module/non-webpack-require-warning/test.filter.js Removes test filter that was disabling this test case
tests/rspack-test/configCases/module/match-module-type/index.js Removes obsolete FIXME comment
tests/rspack-test/configCases/module/issue-17014-webworker/test.filter.js Removes test filter that was disabling this test case

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing 110af6c to fix: should increase the counter of sized in mangle exports plugin (#12044) by harpsealjs

❌ Size increased by 5.88KB from 47.84MB to 47.85MB (⬆️0.01%)

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 31, 2025

CodSpeed Performance Report

Merging #12053 will not alter performance

Comparing fix/get-chunk-filename-dependon (110af6c) with main (bd93cf1)

Summary

✅ 17 untouched

@LingyuCoder LingyuCoder merged commit d808219 into main Oct 31, 2025
124 of 131 checks passed
@LingyuCoder LingyuCoder deleted the fix/get-chunk-filename-dependon branch October 31, 2025 09:54
@h-a-n-a h-a-n-a mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants