fix: should disable default splitChunks rules for EsmLibraryPlugin#12047
Merged
fix: should disable default splitChunks rules for EsmLibraryPlugin#12047
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
release: bug fix
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the splitChunks initialization logic in EsmLibraryPlugin.ts to simplify the code structure and use nullish coalescing for cacheGroups initialization.
- Adds explicit initialization of
splitChunkswhen it's undefined - Replaces conditional
cacheGroupsinitialization with nullish coalescing operator - Unconditionally sets
cacheGroups.defaultandcacheGroups.defaultVendorstofalse
Comments suppressed due to low confidence (1)
packages/rspack/src/builtin-plugin/EsmLibraryPlugin.ts:32
- Assignment to variable splitChunks, which is declared constant.
splitChunks = {};
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
previously approved these changes
Oct 30, 2025
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.85MB |
JSerFeng
force-pushed
the
fix/esm-lib-split-chunks
branch
from
697715a to
d2c233f
Compare
CodSpeed Performance ReportMerging #12047 will not alter performanceComparing Summary
|
Timeless0911
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EsmLibraryPlugin do no needs the default splitChunks rules
Related links
Checklist