Skip to content

test: fix rstest tests not found in windows#11995

Merged
LingyuCoder merged 1 commit intomainfrom
rstest-windows
Oct 24, 2025
Merged

test: fix rstest tests not found in windows#11995
LingyuCoder merged 1 commit intomainfrom
rstest-windows

Conversation

@9aoy
Copy link
Contributor

@9aoy 9aoy commented Oct 24, 2025

Summary

fix rstest tests not found in windows

before:
image

after:
image

https://github.com/web-infra-dev/rspack/actions/runs/18772103400/job/53559042781?pr=11995

Related links

web-infra-dev/rstest#645

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 24, 2025 06:53
@netlify
Copy link

netlify bot commented Oct 24, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 87b0b14
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68fb22789c752200087e4044

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where rstest tests were not being discovered on Windows by correcting the test file pattern in the configuration.

Key Changes:

  • Updated the test file inclusion pattern from an absolute path pattern to a relative pattern to ensure cross-platform compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 24, 2025
@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing 87b0b14 to fix: compilation.*_dep.added should not contains updated files (#11991) by jinrui

🙈 Size remains the same at 47.85MB

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 24, 2025

CodSpeed Performance Report

Merging #11995 will not alter performance

Comparing rstest-windows (87b0b14) with main (8319eeb)

Summary

✅ 17 untouched

@LingyuCoder LingyuCoder merged commit 1d66f6b into main Oct 24, 2025
49 checks passed
@LingyuCoder LingyuCoder deleted the rstest-windows branch October 24, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments