Skip to content

Comments

feat(rspack): add create fn exporter#10841

Closed
ityuany wants to merge 4 commits intoweb-infra-dev:mainfrom
ityuany:feat/add-create-fn-export
Closed

feat(rspack): add create fn exporter#10841
ityuany wants to merge 4 commits intoweb-infra-dev:mainfrom
ityuany:feat/add-create-fn-export

Conversation

@ityuany
Copy link
Contributor

@ityuany ityuany commented Jun 30, 2025

Summary

I need to customize a Rust-based plugin and would prefer to directly use built-in functions when bridging at the JS layer.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jun 30, 2025
@netlify
Copy link

netlify bot commented Jun 30, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d6d3cb
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68624ac6bd5a3c0008f31be3

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an internal API and not ready for public use yet. @hardfist cc

@ityuany
Copy link
Contributor Author

ityuany commented Jun 30, 2025

This is an internal API and not ready for public use yet. @hardfist cc

Are you considering the explicit release of unStableDefineRspackPlugin?

@hardfist
Copy link
Contributor

hardfist commented Jun 30, 2025

@ityuany this plugin register api is too internal to become a public api(even for experimental usage), we have designed some official way to register builtin plugin for rust api integration, @h-a-n-a will share it

@ityuany
Copy link
Contributor Author

ityuany commented Jun 30, 2025

@ityuany this plugin register api is too internal to become a public api(even for experimental usage), we have designed some official way to register builtin plugin for rust api integration, @h-a-n-a will share it

Okay, then I will first implement it in a more wizard-like way, looking forward to @h-a-n-a's sharing.

@ityuany ityuany closed this Jun 30, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 30, 2025

CodSpeed Performance Report

Merging #10841 will not alter performance

Comparing ityuany:feat/add-create-fn-export (9d6d3cb) with main (7637ddf)

Summary

✅ 16 untouched benchmarks

@h-a-n-a
Copy link
Contributor

h-a-n-a commented Jul 1, 2025

@ityuany Moved to #10857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants