Skip to content

refactor: make merge modified files and removed files #10662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Jun 14, 2025
Merged

refactor: make merge modified files and removed files #10662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions crates/rspack_core/src/compiler/make/cutout/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ impl Cutout {
}
}));
}
MakeParam::ModifiedFiles(files) => {
MakeParam::ModifiedFiles(files) | MakeParam::RemovedFiles(files) => {
for module in module_graph.modules().values() {
// check has dependencies modified
if module.depends_on(&files) {
Expand All @@ -67,28 +67,6 @@ impl Cutout {
}
}
}
MakeParam::RemovedFiles(files) => {
for module in module_graph.modules().values() {
// check has dependencies modified
if module.depends_on(&files) {
// add module id
force_build_modules.insert(module.identifier());
// process module dependencies
for connect in module_graph.get_incoming_connections(&module.identifier()) {
force_build_deps.insert(connect.dependency_id);
}
}
}
for dep_id in &artifact.make_failed_dependencies {
let dep = module_graph
.dependency_by_id(dep_id)
.expect("should have dependency");
let info = FactorizeInfo::get_from(dep).expect("should have factorize info");
if info.depends_on(&files) {
force_build_deps.insert(*dep_id);
}
}
}
MakeParam::ForceBuildDeps(deps) => {
force_build_deps.extend(deps);
}
Expand Down
Loading